Ticket #229 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

test_server.TestProtocolError: test hasReturnTo() when message=None.

Reported by: https://keturn.myopenid.com/ Assigned to: http://carl.myopenid.com/
Priority: major Milestone: Lib release 6/5
Keywords: sync Cc:
Project: php-openid OpenID Protocol:
Series: 2.x.x Web Browser:

Description

  * test_server.TestProtocolError: test hasReturnTo() when message=None.
  We had a "if False is not None" in ProtocolError.hasReturnTo.
    {
    hunk ./openid/server/server.py 1599
    -            return False
    +            return None
    hunk ./openid/test/test_server.py 134
    +
    +    def test_noMessage(self):
    +        e = server.ProtocolError(None, "no moar pancakes")
    +        self.failIf(e.hasReturnTo())
    +        self.failUnlessEqual(e.whichEncoding(), None)
    }

Change History

06/04/08 16:44:54 changed by http://carl.myopenid.com/

  • owner set to http://carl.myopenid.com/.
  • status changed from new to assigned.

06/04/08 16:56:45 changed by http://carl.myopenid.com/

  • status changed from assigned to closed.
  • resolution set to fixed.