Ticket #234 (closed defect: fixed)

Opened 4 months ago

Last modified 3 months ago

TrustRoot.checkSanity will raise an exception if the input does not parse

Reported by: http://carl.myopenid.com/ Assigned to:
Priority: major Milestone: Bugfix Release
Keywords: Cc:
Project: python-openid OpenID Protocol:
Series: 2.x.x Web Browser:

Description

>>> from openid.server import trustroot
>>> trustroot.TrustRoot.checkSanity('something invalid')
Traceback (most recent call last):
  File "<stdin>", line 1, in ?
  File "./openid/server/trustroot.py", line 290, in checkSanity
    return cls.parse(trust_root_string).isSane()
AttributeError: 'NoneType' object has no attribute 'isSane'

It should either raise an appropriate, documented exception or return False.

Change History

06/25/08 16:37:01 changed by http://keturn.myopenid.com/

  • milestone set to Bugfix Release.

06/25/08 17:07:17 changed by http://keturn.myopenid.com/

  • status changed from new to closed.
  • resolution set to fixed.