Ticket #286 (new defect)

Opened 4 months ago

Last modified 3 months ago

Use request.query_parameters instead of knocking out request.path_parameters

Reported by: http://antiarc.livejournal.com/ Assigned to:
Priority: major Milestone:
Keywords: Cc:
Project: ruby-openid OpenID Protocol:
Series: 2.x.x Web Browser:

Description

Some routing in Rails 2.1 seems to add additional paramters to the params hash which don't appear in request.path_parameters. To that end, if you use:

params_with_path = request.query_parameters

rather than

params_with_path = params.reject { |key, value| request.path_parameters[key] } params_with_path.delete(:format)

You don't end up with those bogus parameters in the hash, and open ID authentication doesn't fail. It seems to be more "correct" as well.

Change History

09/11/08 16:06:26 changed by http://keturn.myopenid.com/

  • project set to ruby-openid.
  • series set to 2.x.x.